532349 - [10.6] Unable to specific Heiti TC as font in any way (config or CSS)

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

See attachments of Bug #532346: attachment 415587 [details] and attachment 415589 [details]

Reproducible: Always

Steps:
* Set Heiti TC as default zh-TW font in preference plane (effectively changing font.name.*.zh-TW), or 
* Simply put "Heiti TC" in CSS font-family property of any HTML tag.

Result:
Firefox failed to show paragraphs in Heiti TC (The new zh-TW font shipped with 10.6) whatever font-family was written.

Expected Result:
Firefox should render text in Heiti TC.

Tim

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Note: in attachment 415589 [details] the paragraph suppose to show Heiti TC is rendered in LiGothic, which is rendered incorrect as reported bug 532346.

Comment 2

[Irvin (MozTW)]

Attachment: Firefox 3.5.5 Mac OS X 10.6.png

Comment 3

[Irvin (MozTW)]

Attachment: Firefox 3.6b4 OS X 10.6

Comment 4

[Irvin (MozTW)]

Attachment: Safari 4.0.4 Mac OS X 10.6

Comment 5

[Irvin (MozTW)]

Attachment: Firefox 3.5.5 Mac OS X 10.6

Comment 6

[Irvin (MozTW)]

Attachment: Firefox 3.6b4 OS X 10.6

Comment 7

[Irvin (MozTW)]

Attachment: Safari 4.0.4 Mac OS X 10.6

Comment 8

[Irvin (MozTW)]

Attachment: Heiti TC font detail

Comment 9

[Irvin (MozTW)]

Attachment: Test case

Comment 10

[Irvin (MozTW)]

I'd made an another page to do more test on the issue, as attachment "Test case" or http://hd.sto.tw/fxfont-HeitiTC.html

I put all reasonable name of "Heiti TC" in CSS font-family, none of them work on Fx 3.5.5 and 3.6b4. 
(You can look "Heiti TC font detail" and html code in "test case")

I also tried Safari 4.0.4 on the test case, as "Safari 4.0.4 Mac OS X 10.6" shows, PostScript name and Family name work proper for the test case.

Irvin

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to comment #10)
> I'd made an another page to do more test on the issue, as attachment "Test
> case" or http://hd.sto.tw/fxfont-HeitiTC.html
Irvin, could you post a screenshot in Safari to see which ones of them are (legit) fonts names supported by it?

Comment 12

[Irvin (MozTW)]

See attachment: Safari 4.0.4 Mac OS X 10.6   (150.57 KB, image/png) 
https://bugzilla.mozilla.org/attachment.cgi?id=415610

Comment 13

[John Daggett (:jtd)]

We should be matching the family name.  Not matching the Postscript name is intentional, that's non-standard Safari-only behavior.  I'll check this out when I get into the office this morning.

Comment 14

[Jonathan Kew [:jfkthame]]

Attachment: accept new encoding ID for supplementary-plane cmap table

The problem is that these fonts (Heiti TC and SC, and possibly others Apple is now shipping - I didn't check them all) are using a new encoding ID value in their platform 0, format 12 (supplementary-plane) cmap subtables, and our cmap-reading code doesn't recognize and accept it. Therefore, although we have the font in our font list, we conclude that it doesn't support any of the characters, and fall back to something else.

The attached patch accepts encoding ID 0 ("default Unicode semantics"), and any encoding ID >= 3, on the basis that 3 is documented as "Unicode 2.0 or later"; Apple is now using ID 4, presumably for Unicode 5, and it seems likely that any future increment would correspond to a further upwardly-compatible Unicode revision.

Comment 15

[Jonathan Kew [:jfkthame]]

Attachment: screenshot of the testcode with patched Minefield build

This screenshot shows that with the cmap encoding ID patch, the Heiti TC font works as expected when specified by either English or Chinese family names.

Comment 16

[John Daggett (:jtd)]

Comment on attachment 415893 [details] [diff] [review]
accept new encoding ID for supplementary-plane cmap table

Looks good.  I think we need to also land this on 1.9.2 and 1.9.1.x.

Comment 17

[Jonathan Kew [:jfkthame]]

Comment on attachment 415893 [details] [diff] [review]
accept new encoding ID for supplementary-plane cmap table

Requesting approval for 1.9.2. I don't feel I can justify requesting blocking, but it does seem pretty important to land this; without it, the browser can't use the new Chinese fonts Apple ships in 10.6.

Comment 18

[Jonathan Kew [:jfkthame]]

Pushed http://hg.mozilla.org/mozilla-central/rev/fc916a0487c3

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I landed this on 1.9.2 for you:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6300069b98db

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Marking the 14 bugs that are both:
 * nominated for blocking1.9.3:?
 * fixed on the 1.9.2 branch (according to status1.9.2)
as blocking1.9.3:alpha1, so that we don't have to go through the nominations individually.  They're all fixed already (so there's no work to do), and being fixed on 1.9.2 means they probably do block 1.9.3.